Skip to content

bpo-44863: In TypedDict allow inherit from Generic and preserve bases#27663

Merged
JelleZijlstra merged 40 commits intopython:mainfrom
sransara:py-generic-typeddict-simple
May 3, 2022
Merged

bpo-44863: In TypedDict allow inherit from Generic and preserve bases#27663
JelleZijlstra merged 40 commits intopython:mainfrom
sransara:py-generic-typeddict-simple

Conversation

@sransara
Copy link
Contributor

@sransara sransara commented Aug 7, 2021

Copied from: https://bugs.python.org/issue44863

TypedDict PEP-589 says:
A TypedDict cannot inherit from both a TypedDict type and a non-TypedDict base class.

So the current implementation has:
if type(base) is not _TypedDictMeta: raise TypeError(...)

This restricts the user from defining generic TypedDicts in the natural class based syntax:
class Pager(TypedDict, Generic[T]): ...

Although PEP 589 doesn't explicitly state generic support, I believe it is complete in covering the specification even if generics were involved (at least for the class based syntax).

I have tried putting together a PEP from guidance of typing-sig https://github.com/sransara/py-generic-typeddict/blob/master/pep-9999.rst. There is not much new contributions by that draft, except for specifying the alternative syntax and being more explicit about Generics.

So I'm wondering if it would be possible to relax the constraint: TypedDict inheritance to include Generic. In my point of view Generic is more of a mixin, so it doesn't go against the PEP 589. Or is this change big enough to warrant a PEP?

https://bugs.python.org/issue44863

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.